Treat the build directory as an optional #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mernst
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the failed build of plume-lib/options#442 for me when testing locally. @mernst can you confirm that this is fixing the issues that you are seeing?
The problem was that #295 assumed that the build directory could be directly converted to a string. This is true sometimes (I do not understand Gradle well enough to tell you when), but not always - sometimes there is a wrapper around it. Calling
get()first removes the wrapper and allows the plugin to get the build directory location as a string, which is what we wanted. I tested this with bothoptionsand with the local test I created for #295 based on @Calvin-L's report in #294, and it works in both setups. But, I don't have much confidence that this is really the "right" fix.