Skip to content
This repository has been archived by the owner on Jul 20, 2021. It is now read-only.

Allow for supplying config in code #46

Merged
merged 1 commit into from Nov 20, 2015
Merged

Allow for supplying config in code #46

merged 1 commit into from Nov 20, 2015

Conversation

ghost
Copy link

@ghost ghost commented Nov 12, 2015

This seems like an edge case, but it would be nice to have this.
One case would be for example DavyJonesLocker/ember-suave#77.
To enable a single rule in a test.

@kellyselden
Copy link
Owner

I like it. Can you add something to the readme please to document how to use?

@ghost
Copy link
Author

ghost commented Nov 16, 2015

@kellyselden added a bit of README!

kellyselden pushed a commit that referenced this pull request Nov 20, 2015
@kellyselden kellyselden merged commit bb49778 into kellyselden:master Nov 20, 2015
@kellyselden
Copy link
Owner

Thank you!

@ghost ghost deleted the allow-manual-addition-of-rules branch November 20, 2015 14:10
@kellyselden kellyselden mentioned this pull request Nov 20, 2015
@kellyselden
Copy link
Owner

released 1.2.0

@ghost
Copy link
Author

ghost commented Nov 20, 2015

$ ember s
version: 1.13.12
Rule "disallowVar" is already registered
AssertionError: Rule "disallowVar" is already registered
    at NodeConfiguration.Configuration.registerRule (/Users/martenschilstra/Projects/Fabriquartz/planboard-addon/node_modules/ember-suave/node_modules/broccoli-jscs/node_modules/jscs/lib/config/configuration.js:864:5)
    at NodeConfiguration.Configuration._loadAdditionalRule (/Users/martenschilstra/Projects/Fabriquartz/planboard-addon/node_modules/ember-suave/node_modules/broccoli-jscs/node_modules/jscs/lib/config/configuration.js:825:10)
    at NodeConfiguration.<anonymous> (/Users/martenschilstra/Projects/Fabriquartz/planboard-addon/node_modules/ember-suave/node_modules/broccoli-jscs/node_modules/jscs/lib/config/node-configuration.js:213:61)
    at Array.forEach (native)
    at NodeConfiguration._loadAdditionalRule (/Users/martenschilstra/Projects/Fabriquartz/planboard-addon/node_modules/ember-suave/node_modules/broccoli-jscs/node_modules/jscs/lib/config/node-configuration.js:211:61)
    at NodeConfiguration.<anonymous> (/Users/martenschilstra/Projects/Fabriquartz/planboard-addon/node_modules/ember-suave/node_modules/broccoli-jscs/node_modules/jscs/lib/config/configuration.js:502:18)
    at Array.forEach (native)
    at NodeConfiguration.Configuration._processConfig (/Users/martenschilstra/Projects/Fabriquartz/planboard-addon/node_modules/ember-suave/node_modules/broccoli-jscs/node_modules/jscs/lib/config/configuration.js:501:33)
    at NodeConfiguration.Configuration._loadPreset (/Users/martenschilstra/Projects/Fabriquartz/planboard-addon/node_modules/ember-suave/node_modules/broccoli-jscs/node_modules/jscs/lib/config/configuration.js:748:10)
    at NodeConfiguration._loadPreset (/Users/martenschilstra/Projects/Fabriquartz/planboard-addon/node_modules/ember-suave/node_modules/broccoli-jscs/node_modules/jscs/lib/config/node-configuration.js:163:41)

@kellyselden I think this broke something. Can you release a new version with this PR reverted?

@kellyselden
Copy link
Owner

reverted in 1.2.1

@ghost
Copy link
Author

ghost commented Nov 20, 2015

@kellyselden I'm sorry, but accidentaly JSCS also released a version today. They took a rule from ember-suave which cause this conflict. Sorry for the inconvienience but you can unrevert the reversion 😅

@kellyselden
Copy link
Owner

Haha these things happen. I will re-release later today.

@kellyselden
Copy link
Owner

published 1.2.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants