Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encryption-config.yaml is missing issue #780

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chiukapoor
Copy link

@chiukapoor chiukapoor commented May 10, 2024

Updates

  • Add configs/encryption-config.yaml file
  • Update .gitignore to not ignore configs/encryption-config.yaml file

Issue

* update .gitignore to not ignore configs/encryption-config.yaml file

Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
@mikerybka
Copy link

Right on!

@kbenson
Copy link

kbenson commented May 21, 2024

Just ran into this problem and had to look up an issue to find a solution. If this ensures the file is present, seems like it should be accepted. The directions as written have a breaking bug without this.

@chiukapoor
Copy link
Author

@kelseyhightower please review the PR.

@@ -0,0 +1,11 @@
kind: EncryptionConfig
apiVersion: v1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, this throws an error. But this works:

Suggested change
apiVersion: v1
apiVersion: apiserver.config.k8s.io/v1

@DEmmons
Copy link

DEmmons commented Jun 18, 2024

This is a great help, but there's an issue with this approach - in the course of completing lab 06-data-encryption-keys.md a copy of this file is made in the root of the repo, with the encryption key in it. The .gitignore entry is needed to prevent this from being committed back to the repo when changes are made. a simple solution is to name the missing file 'configs/encryption-config-template.yaml' so .gitignore will not match it, and update the relevant line in 06-data-encryption-keys.md accordingly to reference it.

[edit: never mind, this is already addressed]

@chiukapoor
Copy link
Author

This is a great help, but there's an issue with this approach - in the course of completing lab 06-data-encryption-keys.md a copy of this file is made in the root of the repo, with the encryption key in it. The .gitignore entry is needed to prevent this from being committed back to the repo when changes are made. a simple solution is to name the missing file 'configs/encryption-config-template.yaml' so .gitignore will not match it, and update the relevant line in 06-data-encryption-keys.md accordingly to reference it.

The .gitingore file still prevents encryption-config.yaml in the root of the repo from being accidentally committed. I just have added another condition to allow the encryption-config.yaml in the configs folder

@richabanker
Copy link

Also ran into this recently, thanks for the PR!

@benjaminapetersen
Copy link

Working on this today as well and noticed the missing file. 👍

@oates
Copy link

oates commented Jul 8, 2024

I came looking for a PR on this before doing the work myself. I also ran into the issue and had to do a workaround by manually creating the file. Having the file in the config folder would resolve the issue. Thanks for the PR @chiukapoor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configs/encryption-config.yaml is missing
8 participants