Add regenerate-keys option to Issue command to always regenerate key pair #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks pretty fine. Do you want to add a corresponding option to |
kelunik
reviewed
Nov 13, 2017
src/Commands/Issue.php
Outdated
| $keyPair = (new OpenSSLKeyGenerator)->generate($bits); | ||
| $keyPair = (yield $keyStore->put($path, $keyPair)); | ||
| } | ||
| else { |
There was a problem hiding this comment.
Please move that to the previous line (} else {) and indent the code with four spaces.
|
Thanks for replying! I have force-pushed that commit with code styling changes. I'm sorry for not paying attention to code styling. I'll also work on changes in the |
|
@Ayesh Do you still plan to work on |
|
I'm so sorry about the delay on my side. I have made some progress and will commit them later today. Thank you for the follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hallo Niklas,
Thanks for this great acme client. I use it almost every day in many servers I manage, and it's working quite well!
Currently,
acme-clientreuses existing private key if one is present in the pointed storage directory. This is one difference between EFF'scertbot; By default,certbotalways regenerates a new private key on each renewal. Withacme-client, one has to delete the existing private key or point to a different directory to makeacme-clientgenerate a new key. None of these options are convenient as a command line option.I added one, and it seems to work OK at my end. I'm sending a PR hoping you could take a look, and perhaps merge if you think it suits.
Thank you 👍🎉