Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandbox/action pmd test #5

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Sandbox/action pmd test #5

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3d23943
Add unuse filed
kemsakurai Oct 30, 2022
2902a4f
Merge branch 'master' into sandbox/action-pmd-test
kemsakurai Oct 30, 2022
ff342e8
Update Hot.java
kemsakurai Oct 30, 2022
eac6121
Add unused code
kemsakurai Oct 31, 2022
65daf6d
Delete checkstyle,yml
kemsakurai Oct 31, 2022
d9f3d78
Merge branch 'master' into sandbox/action-pmd-test
kemsakurai Oct 31, 2022
aae0114
Add field variable unused4
kemsakurai Nov 6, 2022
eb77888
Add field valiable unused5
kemsakurai Nov 6, 2022
c8d0ac4
Update handler
Nov 19, 2022
4505894
Add unused field
kemsakurai Nov 19, 2022
f60d9c1
Add unused field
kemsakurai Nov 19, 2022
87b8ee5
Add unused9
kemsakurai Nov 19, 2022
2a722d2
Add unused field
kemsakurai Nov 19, 2022
0a80846
Update Hot.java
kemsakurai Nov 13, 2023
c3bea05
Create README.md
kemsakurai Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/pmd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ jobs:
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
reporter: 'github-pr-review'
tool_name: 'pmd_reviewdog'
src_path: ./
tool_name: 'pmd_reviewdog'
9 changes: 8 additions & 1 deletion src/main/java/xyz/monotalk/social/mixcloud/Hot.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,14 @@
*/
public class Hot implements Pathable<MixCloudResult<CloudCast>>, RequesterBuilder {

private String unused = null;
private String unused1 = null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pmd_reviewdog] reported by reviewdog 🐶
Avoid unused private fields such as 'unused1'.

private String unused2 = null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pmd_reviewdog] reported by reviewdog 🐶
Avoid unused private fields such as 'unused2'.

private String unused3 = null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pmd_reviewdog] reported by reviewdog 🐶
Avoid unused private fields such as 'unused3'.

private String unused4 = null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pmd_reviewdog] reported by reviewdog 🐶
Avoid unused private fields such as 'unused4'.

private String unused5 = null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pmd_reviewdog] reported by reviewdog 🐶
Avoid unused private fields such as 'unused5'.

private String unused6 = null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pmd_reviewdog] reported by reviewdog 🐶
Avoid unused private fields such as 'unused6'.

private String unused7 = null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pmd_reviewdog] reported by reviewdog 🐶
Avoid unused private fields such as 'unused7'.

private String unused8 = null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pmd_reviewdog] reported by reviewdog 🐶
Avoid unused private fields such as 'unused8'.

private Pathable pathable = null;

/**
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/xyz/monotalk/social/mixcloud/MixCloudResponseHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ public class MixCloudResponseHandler<R> implements ResponseHandler<R> {

private Pathable<R> pathable = null;

private String unuse7 = null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pmd_reviewdog] reported by reviewdog 🐶
Avoid unused private fields such as 'unuse7'.


/**
* MixCloudResponseHandler
*
Expand Down