Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow log level to be set at runtime #267

Merged
merged 10 commits into from
Aug 6, 2024

Conversation

za419
Copy link
Contributor

@za419 za419 commented Jul 31, 2024

I noticed we never allow overriding of the log level from Info, even though we do log at lower levels. This provides a mechanism to fix this - I thought it might be potentially helpful in debugging population errors (as #264 might be).

This partially depends on, and therefore has some similar diffs to, #266.

Default output:
image

With level=Debug (and the ideal Cadence dev music folder):
image

Commandline that sets Debug:
image

za419 added 4 commits July 30, 2024 18:19
I believe this was an accidental add, as the .example file exists and
overwrites the .yml version during install
This allows the logging level to be quickly and temporarily set without
editing and re-editing config files.
docker-compose.yml.example Outdated Show resolved Hide resolved
@kenellorando kenellorando self-requested a review August 1, 2024 04:23
@kenellorando kenellorando self-assigned this Aug 1, 2024
docker-compose.yml.example Outdated Show resolved Hide resolved
src/server/main.go Show resolved Hide resolved
@kenellorando
Copy link
Owner

LGTM!

@kenellorando kenellorando merged commit 5fc54d0 into kenellorando:master Aug 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants