Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deprecated API #1408

Merged
merged 3 commits into from
Oct 15, 2023
Merged

Remove Deprecated API #1408

merged 3 commits into from
Oct 15, 2023

Conversation

nebocco
Copy link
Contributor

@nebocco nebocco commented Apr 28, 2023

announcement からだいぶ時間も経ったので削除しました。

close #961, close #981, close #989, close #1002, close #1031, close #1113.

@nebocco
Copy link
Contributor Author

nebocco commented Apr 30, 2023

今テスト落ちてるんですけど手元だと通っていて原因分かってません、ごめんなさい……

@nebocco
Copy link
Contributor Author

nebocco commented Apr 30, 2023

fork した自分の方の master に対して PR 出してテストかけてみたら通りました。
落ちてるテストがコンテストページを見に行くものであることから察するに、たまたまこの時間帯に AtCoder 側がアクセスを閉ざしていた可能性があります。

https://github.com/nebocco/AtCoderProblems/actions/runs/4844661157/jobs/8633071085?pr=1

@nebocco nebocco marked this pull request as draft April 30, 2023 13:57
@nebocco nebocco marked this pull request as ready for review April 30, 2023 13:58
@kenkoooo
Copy link
Owner

ありがとうございます!必ずやります!

@kenkoooo kenkoooo merged commit 4bd8ed9 into kenkoooo:master Oct 15, 2023
@nebocco nebocco deleted the feature/remove_api branch November 23, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants