Skip to content

Commit

Permalink
[HOPSWORKS-3235] Fix pre_combine_key in Hudi Engine (logicalclocks#716)
Browse files Browse the repository at this point in the history
  • Loading branch information
SirOibaf authored and kennethmhc committed Nov 16, 2022
1 parent 94f2b06 commit 82db3cc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions python/hsfs/core/hudi_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,7 @@ def _setup_hudi_write_opts(self, operation, write_options):
jdbc_url = self._get_conn_str()
hudi_options = {
self.HUDI_KEY_GENERATOR_OPT_KEY: self.HUDI_COMPLEX_KEY_GENERATOR_OPT_VAL,
self.HUDI_PRECOMBINE_FIELD: self._pre_combine_key[0]
if isinstance(pre_combine_key, list)
else pre_combine_key,
self.HUDI_PRECOMBINE_FIELD: pre_combine_key,
self.HUDI_RECORD_KEY: primary_key,
self.HUDI_PARTITION_FIELD: partition_path,
self.HUDI_TABLE_NAME: table_name,
Expand Down
2 changes: 1 addition & 1 deletion python/hsfs/feature_group.py
Original file line number Diff line number Diff line change
Expand Up @@ -732,7 +732,7 @@ def __init__(
feat.name
for feat in self._features
if feat.hudi_precombine_key is True
]
][0]
else:
self._hudi_precombine_key = None

Expand Down

0 comments on commit 82db3cc

Please sign in to comment.