Fix downloads from subfolders #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for this PR. I’ll make sure it gets merged (or #4, which I think overlaps with this). I was the one that added this functionality in the plugin on Craft 2, but I guess I didn’t properly port that part to Craft 3. So I’d also like to get the tests I have on a branch finished, so that this can be consistently tested. |
|
@kennethormandy It's been a while, do you have any progress? |
kennethormandy
added a commit
that referenced
this pull request
Apr 23, 2020
|
Hey thanks for the PR, this is merged and checked with tests now. The next version will have this change. You can give it a try now with: composer require kennethormandy/craft-s3securedownloads:3.0.0-beta.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.