Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very likely bug in error correction constants #7

Closed
ghost opened this issue Jun 4, 2016 · 1 comment
Closed

Very likely bug in error correction constants #7

ghost opened this issue Jun 4, 2016 · 1 comment

Comments

@ghost
Copy link

ghost commented Jun 4, 2016 •
edited by ghost
Loading

I've been experiencing a bug that only effects QR code version-27 with error correction set to Q; All other combinations don't seem effected.

I believe that the source of this bug is an incorrect value in the DATA_BYTES_PER_BLOCK for the combination. (see file ec.rs, line: 415).

Table 9 of the standard states that the number of blocks should be 26 for 24 not 27.

Your input on this matter would be greatly appreciated.

Thank you.
kennytm added a commit that referenced this issue Jun 4, 2016
@kennytm
Fix wrong EC constant of Version-27-Q. Fix issue #7.
26487ad
kennytm added a commit that referenced this issue Jun 4, 2016
@kennytm
Fix wrong EC constant of Version-27-Q. Fix issue #7.
fee9ded
@kennytm
Copy link
Owner

kennytm commented Jun 4, 2016

Fixed in fee9ded. Thanks!

@kennytm kennytm closed this as completed Jun 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kennytm