Skip to content

Commit

Permalink
Rollup merge of rust-lang#47368 - chrisvittal:nll-tests, r=nikomatsakis
Browse files Browse the repository at this point in the history
Add NLL tests for rust-lang#46557 and rust-lang#38899

This adapts the sample code from the two issues into test code.

Closes rust-lang#46557
Closes rust-lang#38899

r? @nikomatsakis
  • Loading branch information
kennytm committed Jan 15, 2018
2 parents 6966f33 + e14720b commit afb1e19
Show file tree
Hide file tree
Showing 4 changed files with 75 additions and 0 deletions.
30 changes: 30 additions & 0 deletions src/test/ui/nll/borrowed-referent-issue-38899.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Regression test for issue #38899

#![feature(nll)]
#![allow(dead_code)]

pub struct Block<'a> {
current: &'a u8,
unrelated: &'a u8,
}

fn bump<'a>(mut block: &mut Block<'a>) {
let x = &mut block;
println!("{}", x.current);
let p: &'a u8 = &*block.current;
//~^ ERROR cannot borrow `*block.current` as immutable because it is also borrowed as mutable
drop(x);
drop(p);
}

fn main() {}
11 changes: 11 additions & 0 deletions src/test/ui/nll/borrowed-referent-issue-38899.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
error[E0502]: cannot borrow `*block.current` as immutable because it is also borrowed as mutable
--> $DIR/borrowed-referent-issue-38899.rs:24:21
|
22 | let x = &mut block;
| ---------- mutable borrow occurs here
23 | println!("{}", x.current);
24 | let p: &'a u8 = &*block.current;
| ^^^^^^^^^^^^^^^ immutable borrow occurs here

error: aborting due to previous error

21 changes: 21 additions & 0 deletions src/test/ui/nll/return-ref-mut-issue-46557.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Regression test for issue #46557

#![feature(nll)]
#![allow(dead_code)]

fn gimme_static_mut() -> &'static mut u32 {
let ref mut x = 1234543; //~ ERROR borrowed value does not live long enough [E0597]
x
}

fn main() {}
13 changes: 13 additions & 0 deletions src/test/ui/nll/return-ref-mut-issue-46557.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
error[E0597]: borrowed value does not live long enough
--> $DIR/return-ref-mut-issue-46557.rs:17:21
|
17 | let ref mut x = 1234543; //~ ERROR borrowed value does not live long enough [E0597]
| ^^^^^^^ temporary value does not live long enough
18 | x
19 | }
| - temporary value only lives until here
|
= note: borrowed value must be valid for lifetime '_#2r...

error: aborting due to previous error

0 comments on commit afb1e19

Please sign in to comment.