Skip to content

Commit c152e98

Browse files
committed
Rollup merge of rust-lang#49166 - dileepbapat:pr-49133, r=nikomatsakis
rust-lang#49133 - Reworded the Error message: "`pub` not needed here" message
2 parents 7fc81fa + a8f59aa commit c152e98

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/librustc_passes/ast_validation.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ impl<'a> AstValidator<'a> {
6767
E0449,
6868
"unnecessary visibility qualifier");
6969
if vis.node == VisibilityKind::Public {
70-
err.span_label(vis.span, "`pub` not needed here");
70+
err.span_label(vis.span, "`pub` not permitted here because it's implied");
7171
}
7272
if let Some(note) = note {
7373
err.note(note);

src/test/ui/error-codes/E0449.stderr

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,21 @@ error[E0449]: unnecessary visibility qualifier
22
--> $DIR/E0449.rs:17:1
33
|
44
LL | pub impl Bar {} //~ ERROR E0449
5-
| ^^^ `pub` not needed here
5+
| ^^^ `pub` not permitted here because it's implied
66
|
77
= note: place qualifiers on individual impl items instead
88

99
error[E0449]: unnecessary visibility qualifier
1010
--> $DIR/E0449.rs:19:1
1111
|
1212
LL | pub impl Foo for Bar { //~ ERROR E0449
13-
| ^^^ `pub` not needed here
13+
| ^^^ `pub` not permitted here because it's implied
1414

1515
error[E0449]: unnecessary visibility qualifier
1616
--> $DIR/E0449.rs:20:5
1717
|
1818
LL | pub fn foo() {} //~ ERROR E0449
19-
| ^^^ `pub` not needed here
19+
| ^^^ `pub` not permitted here because it's implied
2020

2121
error: aborting due to 3 previous errors
2222

0 commit comments

Comments
 (0)