Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message: "pub not needed here" message #49133

Closed
mitsuhiko opened this issue Mar 18, 2018 · 1 comment
Closed

Error message: "pub not needed here" message #49133

mitsuhiko opened this issue Mar 18, 2018 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@mitsuhiko
Copy link
Contributor

It's a minor thing but currently "pub' not needed here" is an error and does not actually mean "needed" but "allowed because implied". Maybe the message would be less confusing for a user if it actually says "pub not permitted here because it's implied".
@oli-obk oli-obk added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints labels Mar 18, 2018
dileepbapat added a commit to dileepbapat/rust that referenced this issue Mar 19, 2018
@dileepbapat
rust-lang#49133 - Reworded the Error message: "pub not needed here"…
a8f59aa 
… message
kennytm pushed a commit to kennytm/rust that referenced this issue Mar 19, 2018
@dileepbapat
rust-lang#49133 - Reworded the Error message: "pub not needed here"…
3799866 
… message
kennytm added a commit to kennytm/rust that referenced this issue Mar 20, 2018
@kennytm
Rollup merge of rust-lang#49166 - dileepbapat:pr-49133, r=nikomatsakis
c152e98 
rust-lang#49133 - Reworded the Error message: "`pub` not needed here" message
@estebank
Copy link
Contributor

Fixed in #49166.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mitsuhiko @oli-obk @estebank