Rollup merge of rust-lang#53801 - GuillaumeGomez:duplicated-foreign-t…

…ype-impls, r=QuietMisdreavus Prevent duplicated impl on foreign types Fixes rust-lang#53689. r? @QuietMisdreavus
kennytm · Sep 1, 2018 · f370814 · f370814
2 parents 88ebbe9 + 3b98571
commit f370814
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/src/librustdoc/html/render.rs b/src/librustdoc/html/render.rs
@@ -2956,12 +2956,16 @@ fn item_trait(
                 </h2>
             ")?;
 
+            let mut foreign_cache = FxHashSet();
             for implementor in foreign {
-                let assoc_link = AssocItemLink::GotoSource(
-                    implementor.impl_item.def_id, &implementor.inner_impl().provided_trait_methods
-                );
-                render_impl(w, cx, &implementor, assoc_link,
-                            RenderMode::Normal, implementor.impl_item.stable_since(), false)?;
+                if foreign_cache.insert(implementor.inner_impl().to_string()) {
+                    let assoc_link = AssocItemLink::GotoSource(
+                        implementor.impl_item.def_id,
+                        &implementor.inner_impl().provided_trait_methods
+                    );
+                    render_impl(w, cx, &implementor, assoc_link,
+                                RenderMode::Normal, implementor.impl_item.stable_since(), false)?;
+                }
             }
         }