Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRA note to caveats #83

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Add CRA note to caveats #83

merged 1 commit into from
Oct 3, 2018

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Oct 3, 2018

What:

Note that Create React App does not suffer from a common problem using Macros.

Why:

facebook/create-react-app#2730 (comment)

We don't want users thinking they have to purge the cache, as this will be very detrimental to their rebuild speed.
It's also important because these configuration values are out of their reach; ejecting to "fix" this would be unnecessary.

facebook/create-react-app#2730 (comment)

We don't want users thinking they have to purge the cache, as this will be very detrimental to their rebuild speed.
@codecov
Copy link

codecov bot commented Oct 3, 2018

Codecov Report

Merging #83 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #83   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          80     80           
  Branches       19     19           
=====================================
  Hits           80     80

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1785a0f...d5a1caf. Read the comment docs.

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks. Maybe we could add documentation on what people can do in their own webpack/Babel config to avoid the problem for themselves.

@kentcdodds kentcdodds merged commit a96544e into kentcdodds:master Oct 3, 2018
@Timer Timer deleted the patch-1 branch October 3, 2018 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants