Skip to content
This repository has been archived by the owner on Dec 7, 2018. It is now read-only.

Feature/search #219

Closed
wants to merge 2 commits into from
Closed

Conversation

RIanDeLaCruz
Copy link

@RIanDeLaCruz RIanDeLaCruz commented Jul 10, 2017

What: Added Search functionality via Algolia

Why: Site Usability

How: Using Algolia DocSearch

@RIanDeLaCruz
Copy link
Author

I'm not sure, at this point, how to style.

Tried using Glamorous itself but it seems as if I am missing something for the style to appear

@RIanDeLaCruz
Copy link
Author

RIanDeLaCruz commented Jul 10, 2017

screen shot 2017-07-10 at 9 09 17 pm

Add Algolia Config component

Add Instant Search package

Use DocSearch instead of InstantSearch

Working DocSearch

Working DocSearch

Update selector to use underscore

Added Search box to Nav
@kentcdodds
Copy link
Owner

Thanks @RIanDeLaCruz! I just force-pushed to your branch to resolve some merge conflicts (your branch was pretty out of date 😅). Please make sure you pull before doing any more work.

Could we get help here from someone? How should we style this? cc @jonmajorc, do you have any ideas?

By the way, this is AWESOME!!!!

search

@RIanDeLaCruz
Copy link
Author

Thanks! 😄

@codecov
Copy link

codecov bot commented Jul 10, 2017

Codecov Report

Merging #219 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #219      +/-   ##
=========================================
+ Coverage   95.87%   95.9%   +0.02%     
=========================================
  Files          30      30              
  Lines         291     293       +2     
  Branches       37      37              
=========================================
+ Hits          279     281       +2     
  Misses         12      12
Impacted Files Coverage Δ
components/nav.js 85.71% <100%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510293b...b455c7c. Read the comment docs.

@kentcdodds kentcdodds mentioned this pull request Jul 12, 2017
@motleydev
Copy link
Contributor

Ok, I have a style to be reviewed. I'm running into some knowledge limit with github though. :) How do I push my version of this branch back to this feed? I added this branch as a remote but I am assuming I don't have write access?

@motleydev
Copy link
Contributor

search-interaction

@motleydev motleydev mentioned this pull request Jul 13, 2017
@kentcdodds
Copy link
Owner

Closing in favor of #235

@kentcdodds kentcdodds closed this Jul 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants