Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix processing rules with additional appended classes, i.e. &.someclass #22

Merged
merged 2 commits into from
Nov 6, 2017

Conversation

asvetliakov
Copy link
Collaborator

@asvetliakov asvetliakov commented Nov 4, 2017

What:
Fix the output when css rule have only something like this:

  &.active {
    background:green;
  }

Previously it was skipped from output due to wrong filtering in getStyles()

How:
See getStyles in serializer.js in PR

@codecov
Copy link

codecov bot commented Nov 4, 2017

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #22   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          65     66    +1     
  Branches       13     14    +1     
=====================================
+ Hits           65     66    +1
Impacted Files Coverage Δ
src/serializer.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84ace7c...6e7c86a. Read the comment docs.

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you 👍

@kentcdodds kentcdodds merged commit 5abdf6e into kentcdodds:master Nov 6, 2017
@kentcdodds
Copy link
Owner

Would you like to add yourself to the contributors table?

@kentcdodds
Copy link
Owner

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

@asvetliakov asvetliakov deleted the appended-class branch November 6, 2017 05:47
@asvetliakov
Copy link
Collaborator Author

Thanks! I'll add myself to the table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants