Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lint-staged to v10 for consistency #9

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

Belco90
Copy link
Contributor

@Belco90 Belco90 commented Feb 5, 2020

Last version available of lint-staged is v10. On that major release is not necessary anymore to add the "git add" step, and actually has to be removed in case you got it from a previous version.

The course repo itself is fine, as it's using v9 with "git add" step. But then when someone following proper lesson on Testing Javascript installs lint-staged dependency, they'll get v10 and the config steps are not consistent anymore, which could cause them having issues with pre-commit hook.

This PR is updating lint-staged and its config to mirror what people following the course will see, but there are 2 things that must be updated additionally:

@Belco90 Belco90 requested a review from kentcdodds February 5, 2020 12:25
@kentcdodds kentcdodds merged commit 34d73e3 into kentcdodds:master Mar 3, 2020
@kentcdodds
Copy link
Owner

Thank you 👍

@kentcdodds
Copy link
Owner

I'll update the videos at a later time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants