Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a crash on rollups #666

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fixing a crash on rollups #666

merged 1 commit into from
Feb 14, 2024

Conversation

i3149
Copy link
Contributor

@i3149 i3149 commented Feb 10, 2024

Fixing a crash on rollups:

anic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x10 pc=0x103f21a48]

goroutine 98 [running]:
github.com/kentik/ktranslate/pkg/rollup.(*StatsRollup).exportSum(0x14000676000, 0x14000ec0000, 0x0?, 0x102c1c334?, 0x140004939e0?, 0x0?, 0x0?)
	/Users/pye/src/ktranslate/pkg/rollup/stats.go:305 +0x428
created by github.com/kentik/ktranslate/pkg/rollup.(*StatsRollup).sumKvs in goroutine 30
	/Users/pye/src/ktranslate/pkg/rollup/stats.go:271 +0x168
zsh: exit 2     ./bin/ktranslate -nf.source=auto -rollup_interval 30 -filters  -rollups 

I guess no one ever used this code brach /shrug

@i3149 i3149 requested a review from dpajin-kentik February 10, 2024 05:51
@i3149 i3149 merged commit 244947d into main Feb 14, 2024
1 check passed
@i3149 i3149 deleted the fix-rollups branch February 14, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant