Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Infinite Scroll When slideToShow === slideCount when Using centerMode, and asNavFor #1189

Open
leggomuhgreggo opened this issue Mar 27, 2015 · 6 comments

Comments

@leggomuhgreggo
Copy link
Collaborator

leggomuhgreggo commented Mar 27, 2015

There are cases, particularly when syncing sliders, and using center mode, where it's advantageous to be able to slide infinitely while also showing every slide.

Here's a pen to illustrate a scenario with text paired with a corresponding thumb, like a members slider, that reveals bio summary under the centered thumb.

There've been some existing issues #706 #262 that touch on this, and I want to say that it was even functioning this way, in a previous release, but can't say for sure.

I tried breifly to mod a fork to replace:
_.slideCount > _.options.slidesToShow with _.slideCount >= _.options.slidesToShow
but that didn't seem to get it done.

I think at one point there was talk of creating an option to allow this, which would be swell. I was also considering whether it might be a reliable assumption that, when synced with a slider where slideCount does exceed slidesToShow the intent would be to scroll.

Thanks as always for making this awesome slider, and for continuing to find the time to work on it, especially with the new addition in your life.

Edit: Updated with better pen

@vedmant
Copy link

vedmant commented Apr 8, 2015

I've just faced the same problem, I used centerMode, and when first slide selected and 5 of 5 slides are in slider, it shows only next two slides, other 2 slides are out of container and I can't scroll them. And left side from current slide is empty. http://screencast.com/t/hPHIcQ7uZ

@alexfromapex
Copy link

This still appears to be broken in 1.5.9. Is there any way this can be fixed and added as an option to the documentation?

@leggomuhgreggo
Copy link
Collaborator Author

I can tell you that it's been discussed relatively recently. There's a question of what the default behavior should be when slideCount < slidesToShow. Clone? Center? Feel free to share any thoughts you have on implementation.

@stljeff1
Copy link

stljeff1 commented Oct 3, 2017

Are you still thinking about this? I say clone

@tkuther
Copy link

tkuther commented Oct 30, 2017

This still happens in 1.8.1 (without asNavFor)

The issue I'm seeing then is #2115, also the active slide isn't centered, and no infinite scrolling.

@richardwiggins
Copy link

Hey, is there any way around this issue yet? The big issue I have is that I don't even want to scroll any items within the navigation slider (i.e. I have 5 slides and using slidesToShow: 5) but this happens automatically when I autoplay the main slider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants