Slide Option Not Working

[leggomuhgreggo]

Looks like any direct descendant of the slick is considered a slide, even when a jquery string is specified for the slide option.

Here's a pen demonstrating the issue.

Might be related to #1505

Im guessing broke when the slide option changed to defaulting to child elements

Thanks as always to you guys for all your efforts in making such an awesome carousel.

[nominalaeon]

Who put that footer in the slider!?

I've always assumed that slick'ing all descendants was just how it worked. @simeydotme or @kenwheeler, is this supposed to be an option, like a user can send in a selector (array of selectors?) as an argument and have them be ignored? The concept is interesting, I'd like to look into it but I wanted to know if this is pre-existing and borked or if it would be a new feature?

[leggomuhgreggo]

@nominalaeon I totally agree it's a silly use-case. I just noticed it when I was working with some legacy markup and thought I'd alert the authorities #ifyouseesomethingsaysomething ;)

[simeydotme]

I think it's related to my PR: #1357 ... I'll be rebasing an merging all my PRs today, so I'd love it if you could test once I'm done, @leggomuhgreggo and
@nominalaeon 😄 xx

[simeydotme]

Can you have a quick test with the master-branch slick.js file? :)

[leggomuhgreggo]

The slide option is working great! Thanks @simeydotme.

One thing I noticed is the slide gets an outline now, because of default user agent styles for the new tabindex attribute. Easy enough to add outline: 0 on .slide but I wanted to give you a heads up.

Here's a related doc

Edit: Clarity

[simeydotme]

Ah, that's from another dude's PR... #1467 -- is it possible you can give him a heads-up with the before/after screenshots? (i know its asking a lot) eek.

[simeydotme]

also: thanks for testing!! xxx

[leggomuhgreggo]

@simeydotme Happy to help!