Bugfix 327 - Responsive Settings via setOption #1334
Conversation
setOption method. Previously was impossible to set the responsive settings via setOption due to: 1. Settings would never get merged, always would lose previous breakpoints 2. The responsive settings were registered at init, and not at reinit. Added in a specific check for setOption and Responsive to merge new responsive breakpoint options, and over-write existing ones. Moved the breakpoint registration into it's own method and call it on init and reInit. Also breakpoint registration will clear out duplicate breakpoints.
| @@ -1472,6 +1454,46 @@ | |||
|
|
|||
| }; | |||
|
|
|||
| Slick.prototype.registerBreakpoints = function() { | |||
There was a problem hiding this comment.
Can you annotate this? Is it thoroughly tested? Explain what it does and the necessity.
|
Added some annotations, for you, @kenwheeler :) |
|
Thank you so much for the annotations. I need to fiddle with this myself a bit before merging, cause this is a biggum. Well done. |
|
Yeh absolutely mate! - cheers, and it would have been much simpler to de-dupe if the responsive JSON-style array was an indexed-object instead, but I had to work around that architecture 😙 ... Perhaps something to consider for v2 😄 |
|
👍 |
Fixes #327