Fixes #1354 - Race condition on Cloned Lazy Load #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some scenarios (one being slidesToShow: 2, slidesToScroll: 1) the cloned slide would have it's data-lazy removed, but not actually animate it's opacity to 1, leaving an invisible image inside the cloned slide. I narrowed it down to the order of code inside the onload() function, and the code outside of the onload() function. Fixed it by making the loading, animation and attribute settings synchronous using callbacks from the .animate() functions. The setting of opacity: 0; now also has a very fast animation, which makes the loading of images seem less jarring.
simeydotme
added a commit
that referenced
this pull request
May 18, 2015
Fixes #1354 - Race condition on Cloned Lazy Load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some scenarios (one being
slidesToShow: 2,slidesToScroll: 1) thecloned slide would have it's
data-lazyremoved, but not actually animateit's
opacityto1, leaving an invisible image inside the cloned slide.I narrowed it down to the order of code inside the
onload()function, andthe code outside of the
onload()function. Fixed it by making the loading,animation and attribute settings synchronous using callbacks from
the
.animate()functions.The setting of
opacity: 0;now also has a very fast animation, which makesthe loading of images seem less jarring.