Correctly center slider #1901
Open
Correctly center slider #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the slides are centered if slideCount is less than slidesToShow
|
@niaccurshi could you please provide a JS fiddle for before and one for after? Then I can test and merge. |
|
Sorry that I never got back to this, as I mentioned in my other comment I was a little rushed/busy and so only wanted to provide something to highlight a route forward. Is there anything else you need from me on this at this stage? I'm afraid at this point I don't know if I can go back to provide a before or after on JSFiddle |
|
Any updates on the PR? |
|
...never mind, I see that the issue was fixed and merged in #2118. |
|
wfm, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the slides are centered if slideCount is less than slidesToShow.
(This is only the unminified version, haven't the time to do anything other than fix this issue!)