Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1207 White spaces when using variableWidth and infinite to true #2946

Merged
merged 1 commit into from
Jul 29, 2017

Conversation

nicolaspernot
Copy link

Solve the #1207 issues about white spaces when using variableWidth and infinite to true, solution gave by xXanth0s (#1207 (comment))

…paces when using variableWidth and infinite to true, solution gave by xXanth0s (kenwheeler#1207 (comment))
@leggomuhgreggo
Copy link
Collaborator

Hey can you demo your changes in a pen, and then maybe test it against some of the existing functionality in this test template

Thanks!

@nicolaspernot
Copy link
Author

Here is it : https://codepen.io/nicolaspernot/pen/WOZwzQ

I added an example of a slider with variableWidth: true and infinite: true.
Solution is clearly better but seems not perfect when slides width are not exactly the same as the sliders width. But better. I'll try to fix this last bug in a near future.

For the other sliders demos, I noticed no problem, except maybe some changing in green and pinky colors. But I think it's nothing else than CSS improvement.

@leggomuhgreggo
Copy link
Collaborator

@nicolaspernot cool flashing is from the clone swap, and is known issue.

Did you want to go another round on this or you feelin a "perfect is the enemy of good" merge?

@nicolaspernot
Copy link
Author

@leggomuhgreggo I know I will correct the last issue because I work for someone who want it solved. He wants it solved, but it is not his priority. A day I will, for sure :)
So, I think it's for the better to merge now and let's create an issue for the remaining issue.

By the way, yes, i'm a perfect-is-the-enemy-of-good guy :)

@leggomuhgreggo
Copy link
Collaborator

Thanks! Merged

@leggomuhgreggo leggomuhgreggo merged commit ce2d75a into kenwheeler:master Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants