Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not to scroll when infinite scrolling isn't on #3037

Merged
merged 1 commit into from
Sep 12, 2017

Conversation

Munawwar
Copy link
Contributor

@Munawwar Munawwar commented Aug 7, 2017

Hi.

I am seeing a case where swiping the main image causes the nav to scroll even when infinite scroll isn't on.

So.. I am using the following options:

$sliderNav.slick({
    slidesToShow: 4,
    slidesToScroll: 1,
    asNavFor: '.product-detail-slider',
    dots: false,
    vertical: true,
    focusOnSelect: true
});

and the issue happens when the number of images are 3 or less (4 images can fit into the space).
When the number of images are 3, then the infinite scrolling seems to be off (even though infinite option is set to true).
However swiping the main image causes the nav image to scroll off the screen.

You can check the bug here -> https://www.ounass.ae/shop-gucci-pastel-pink-gg-marmont-wallet-211544599.html
It's using slick slider 1.7.1. Try swiping the product image.

So I think this is an issue in slick itself, and applied a fix to the best of my knowledge.

Thanks.

@leggomuhgreggo
Copy link
Collaborator

Merged. Thanks!

@leggomuhgreggo leggomuhgreggo merged commit 86ed071 into kenwheeler:master Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants