-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lazyLoadSourceAttr and lazyLoadTargetAttr #916
base: master
Are you sure you want to change the base?
Conversation
Good feature, I guess it's not going to be merged in ? |
Would be a very useful feature, and would be good if it didn't rely on the container being a div (eg be able to add the data-lazy attribute to an LI tag) |
Instead of I used this
so that I could use A instead of DIV with lazy loaded background. The |
Thats a good point @huan086 ! |
Is this going to be merged within the next time? |
@stha: I would need to fix the conflicts first, but I could update this PR and hope for it to be merged. |
Please fix the conflicts if there is any ... Pinging @kenwheeler |
Are there any progress on it? |
dead? :) |
when rows is more 2 after resize of window loaded images are lost and nothing is shown |
latest version #2538 |
revive? |
Allow to change where lazyLoad gets image src (data attribute) with lazyLoadSourceAttr also allow where lazyLoad will put the image (default src on img-tag).
I have added an extra sourceAttr support for one of my projects where we use divs for images to have them floating inside fixed height. If lazyLoadTargetAttr is 'background-image' then lazyLoad will look for divs with matching sourceAttr and simply set background-image on them.