Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/adjust directories #5

Merged
merged 71 commits into from
Dec 17, 2019
Merged

Feature/adjust directories #5

merged 71 commits into from
Dec 17, 2019

Conversation

kenzo0107
Copy link
Owner

@kenzo0107 kenzo0107 commented Dec 8, 2019 •
edited
Loading

Add unit tests

@kenzo0107
change directory structure
2bf1a50 
aws-sdk-go and strings utility all in a directory. It's difficult for me to manage them.
So I change directory structure.
@kenzo0107
update url golint
c1e65cf
@kenzo0107
version up
5e0d9af
@kenzo0107
Add environment value for credentials path
a87eb3b
@kenzo0107
get profiles from credentilas path
d4ce53b
@kenzo0107
get profiles from credentilas and select profile by fuzzyfinder
7738949
@kenzo0107
⚙️ install google/go-cmp, termbox-go
c317301
@kenzo0107
fmt.Println to log.Println
196ebfd 
All output are integrated with log package.
@kenzo0107
Show test coverage
3966588
@kenzo0107
Add testing about select profile with fuzzyfinder
24db01d
@kenzo0107
Add testing about strings replacement
c8806fe
@kenzo0107
Add testing about empty credentials path
a7670df
@kenzo0107
Add svc parameter in args for testing
754ab81
@kenzo0107
Add testdata
194b40b
@kenzo0107
Change private method from NewSession to newSession
6cb7930
@kenzo0107
Add Testing
c243510
@kenzo0107
Add method that typing keys on termbox for Testing
57cf782
@kenzo0107
Set credentials path if value AWS_SHARED_CREDENTIALS_FILE is set
e493481
@kenzo0107
go mod tidy
5acf289
@kenzo0107
Add golint, gotest to GitHub WorkFlow
5a3d321
@kenzo0107
typo
708c10c
@kenzo0107
typo
4882a9c
@kenzo0107
install golint on github actions
093bf6b
@kenzo0107
Add step "Install dependencies" on GitHub Actions
87f21d8
@kenzo0107
Add static check to GitHub Actions
0faf0a9
@kenzo0107
static check on ubuntu-latest only
8d36f16
@kenzo0107
Add static checks
2eb8cad
@github-actions
Copy link

github-actions bot commented Dec 8, 2019

⚠ errcheck Failed

omssh.go:140:21:	defer session.Close()
pkg/awsapi/ec2_test.go:137:18:	ioutil.WriteFile(fname, []byte(actual), 0644)
pkg/awsapi/session_test.go:11:11:	os.Setenv("AWS_SHARED_CREDENTIALS_FILE", fname)
pkg/utility/profile.go:28:15:	defer f.Close()

@github-actions
Copy link

github-actions bot commented Dec 8, 2019

⚠ gosec Failed

Summary:
   Files: 8
   Lines: 652
   Nosec: 0
  Issues: 2
Show Detail 
Results:


[/github/workspace/pkg/utility/profile.go:23] - G304 (CWE-22): Potential file inclusion via variable (Confidence: HIGH, Severity: MEDIUM)
  > os.Open(fpath)


[/github/workspace/omssh.go:130] - G106 (CWE-322): Use of ssh InsecureIgnoreHostKey should be audited (Confidence: HIGH, Severity: MEDIUM)
  > ssh.InsecureIgnoreHostKey()


Summary:
   Files: 8
   Lines: 652
   Nosec: 0
  Issues: 2

Code Reference

@github-actions
Copy link

github-actions bot commented Dec 8, 2019

⚠ shadow Failed

# github.com/kenzo0107/omssh
./omssh.go:70:6: declaration of "err" shadows declaration at line 47

@github-actions
Copy link

⚠ golint Failed

Found 3 lint suggestions; failing.

Show Detail 
omssh.go:32:1: exported method Device.SSHConnect should have comment or be unexported
omssh.go:48:1: exported method Device.SetupIO should have comment or be unexported
omssh.go:54:1: exported method Device.StartShell should have comment or be unexported

@github-actions
Copy link

⚠ gosec Failed

Summary:
   Files: 9
   Lines: 709
   Nosec: 0
  Issues: 1
Show Detail 
Results:


[/github/workspace/omssh.go:27] - G106 (CWE-322): Use of ssh InsecureIgnoreHostKey should be audited (Confidence: HIGH, Severity: MEDIUM)
  > ssh.InsecureIgnoreHostKey()


Summary:
   Files: 9
   Lines: 709
   Nosec: 0
  Issues: 1

Code Reference

@github-actions
Copy link

⚠ staticcheck Failed

omssh_test.go:13:6: type mockClient is unused (U1000)

Checks Document

@github-actions
Copy link

⚠ golint Failed

Found 3 lint suggestions; failing.

Show Detail 
omssh.go:32:1: exported method Device.SSHConnect should have comment or be unexported
omssh.go:48:1: exported method Device.SetupIO should have comment or be unexported
omssh.go:54:1: exported method Device.StartShell should have comment or be unexported

@github-actions
Copy link

⚠ gosec Failed

Summary:
   Files: 9
   Lines: 712
   Nosec: 0
  Issues: 1
Show Detail 
Results:


[/github/workspace/omssh.go:27] - G106 (CWE-322): Use of ssh InsecureIgnoreHostKey should be audited (Confidence: HIGH, Severity: MEDIUM)
  > ssh.InsecureIgnoreHostKey()


Summary:
   Files: 9
   Lines: 712
   Nosec: 0
  Issues: 1

Code Reference

@github-actions
Copy link

⚠ staticcheck Failed

omssh_test.go:13:6: type mockClient is unused (U1000)

Checks Document

@kenzo0107 kenzo0107 merged commit a6afbb1 into master Dec 17, 2019
@kenzo0107 kenzo0107 deleted the feature/adjust_directories branch December 17, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kenzo0107