Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable emoji output #226

Closed
halostatue opened this issue Jul 26, 2023 · 2 comments · Fixed by #229
Closed

Disable emoji output #226

halostatue opened this issue Jul 26, 2023 · 2 comments · Fixed by #229
Labels
enhancement New feature or request released on @alpha

Comments

@halostatue
Copy link
Contributor

I’d like a configuration option to disable emoji output, because I think it looks worse than PK and NULL, especially if (like me), you’ve been reading ERDs for the last ~30 years.

The minimum would be something like useEmojis = true | false which chooses PK or 🗝️ and NULL or ❓, but better would be something more configurable:

  • emoji only
  • standard text only
  • emoji plus standard text
  • custom text (which can include emoji)

I’ll probably need to roll back to an earlier version because I think that this is a readability regression on an otherwise excellent project. I’d be happy to submit a PR for the minimal approach.
@keonik keonik added the enhancement New feature or request label Aug 7, 2023
@keonik
Copy link
Owner

keonik commented Aug 7, 2023

Makes a lot of sense. I'd be happy to review a PR.

@halostatue halostatue mentioned this issue Aug 7, 2023
Merged
keonik pushed a commit that referenced this issue Aug 8, 2023
@halostatue
feat: Option to disable emoji output (#229)
f86ff4d 
Resolves #226

Because the default would be to generate emoji output (so as to not
result in a regression for those who prefer the emoji output), I have
named the configuration `disableEmoji`. Setting `disableEmoji = true`
reverts the generated code to `PK` and `nullable`.
@github-actions
Copy link

🎉 This issue has been resolved in version 1.10.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Option to disable emoji output
2 participants
@halostatue @keonik