fix: bugfix on tableau interactivity for hex grid #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris DeMartini <chris@datablick.com>
demartsc
force-pushed
the
fix/hexgrid-interactive-v2
branch
from
c81bbd7
to
c148406
Compare
heshan0131
reviewed
Mar 16, 2020
| @@ -65,7 +65,10 @@ function getHoverInfo(info, allData) { | |||
| : // if hovered is a hexbbin, or grid, kepler.gl can return all the points inside that hexagon / grid | |||
| objectHovered.type === 'Feature' | |||
| ? allData[objectHovered.properties.index] | |||
| : objectHovered.points; | |||
| // with upgrade to v2 we now need to the data sub-object for hex and grid layer | |||
| : objectHovered.points.map(pt => { | |||
There was a problem hiding this comment.
there should be a filteredPoints property, that the filtered data. but it is not always defined. It is only there when there is gpu filter. try apply a numeric filter and see if filteredPoints is the correct one to use
There was a problem hiding this comment.
I am going to separate out the enhancement for new selection tool/filtering via this issue/request #22. This PR will be scoped to only fixing the broken functionality around integration with points and/or aggregated marks (e.g., hex layer).
heshan0131
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple update re-enables the interactivity to tableau for hex and grid layers (I hope).