Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize layers by dataset #1658

Closed
heshan0131 opened this issue Nov 30, 2021 · 1 comment
Closed

Organize layers by dataset #1658

heshan0131 opened this issue Nov 30, 2021 · 1 comment
Assignees

Comments

@heshan0131
Copy link
Contributor

heshan0131 commented Nov 30, 2021

Problem

Currently the only way to associate a layer with a dataset is by matching the colors of dataset square with the color border of a layer panel. It would be nice to have a option in the layer panel to organize layers by dataset, display layers as childrens of the dataset it is based on.

Solution

  1. Add a PanelViewListToggle component on top of the layer manager
  2. Add layerPanelListView to uiState reducer. uiState.layerPanelListView = 'list' | 'sortByDataset'
  3. Add toggleLayerPanelListView to uiStateActions
  4. PanelViewListToggle component should render 2 view options list sortByDataset
  5. PanelViewListToggle should call toggleLayerPanelListView to update uiState.layerPanelListView
  6. Default uiStat.layerPanelListView value should be 'list'
  7. Render layer panels group by dataset if layerPanelListView === 'sortByDataset'

UI Design

PanelViewListToggle Component

Screen Shot 2021-11-30 at 10 14 53 AM

Organize layers by dataset

Screen Shot 2021-11-30 at 10 15 01 AM

@heshan0131 heshan0131 self-assigned this Nov 30, 2021
@ibgreen
Copy link
Collaborator

ibgreen commented Nov 30, 2021

Love this!

FWIW, I would personally prefer if the datasets list at the top disappeared in the hierarchical view (and the dataset cards were moved into the tree, replacing the dataset headers).

That dataset list is a bit of a "design crutch" IMHO, it kind of bothers me that the first thing I see in the "layers" tab is a list of "datasets" (although I do understand why it is done this way and I agree that it has some value in the "flat" view).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants