[Enhancement] extract layers list to a separate component #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hodoje <nikolakaraklic@gmail.com>
heshan0131
reviewed
Dec 13, 2021
heshan0131
reviewed
Dec 13, 2021
heshan0131
reviewed
Dec 13, 2021
heshan0131
reviewed
Dec 13, 2021
heshan0131
reviewed
Dec 13, 2021
heshan0131
reviewed
Dec 13, 2021
Signed-off-by: hodoje <nikolakaraklic@gmail.com>
Signed-off-by: hodoje <nikolakaraklic@gmail.com>
Signed-off-by: hodoje <nikolakaraklic@gmail.com>
Signed-off-by: hodoje <nikolakaraklic@gmail.com>
macrigiuseppe
approved these changes
Dec 14, 2021
Signed-off-by: hodoje <nikolakaraklic@gmail.com>
heshan0131
reviewed
Dec 17, 2021
heshan0131
reviewed
Dec 17, 2021
heshan0131
reviewed
Dec 30, 2021
heshan0131
reviewed
Dec 30, 2021
Signed-off-by: hodoje <nkaraklic@foursquare.com>
hodoje
changed the title
Signed-off-by: hodoje <nkaraklic@foursquare.com>
hodoje
changed the title
|
This PR is ready for review. |
Signed-off-by: hodoje <nkaraklic@foursquare.com>
heshan0131
approved these changes
Jan 12, 2022
cesars-gh
added a commit
to alphateamhackers/kepler.gl
that referenced
this pull request
Jan 26, 2022
* [Bug] do not display geocoder dataset in side panel Signed-off-by: hodoje <nikolakaraklic@gmail.com> * [Bug] fix pin table column overide dataset (keplergl#1625) Signed-off-by: Shan He <heshan0131@gmail.com> * [chore] export types, add script to build types (keplergl#1636) - export types, add script to build types - ignore getDistanceScales type check (for now) - upload button to PF - fix localization file compile errors - move translations to translations folder Signed-off-by: Shan He <heshan0131@gmail.com> Signed-off-by: Giuseppe Macri <macri.giuseppe@gmail.com> Co-authored-by: Giuseppe Macrì <macri.giuseppe@gmail.com> * [Enhancement] extract layers list to a separate component (keplergl#1665) Signed-off-by: hodoje <nkaraklic@foursquare.com> * [Enhancement] order layers by dataset (keplergl#1675) * extract layers list to a separate component * organize layers by dataset * add additional toggleLayerPanelListView action * extract add layer button to separate component * remove drag handle when in order by dataset view Signed-off-by: hodoje <nkaraklic@foursquare.com> * [Bug] fix filtered datasets memoization (keplergl#1678) Signed-off-by: hodoje <nkaraklic@foursquare.com> * update package script Co-authored-by: Nikola Karaklic <nikolakaraklic@gmail.com> Co-authored-by: Shan He <heshan0131@gmail.com> Co-authored-by: Giuseppe Macrì <macri.giuseppe@gmail.com> Co-authored-by: Nikola Karaklic <nkaraklic@foursquare.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts the layers list into a separate component which will help the implementation of #1658
Signed-off-by: hodoje nikolakaraklic@gmail.com