[Chore]: Technical: Translate table utils #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
heshan0131
reviewed
Mar 18, 2022
| */ | ||
| export function createDataContainer( | ||
| data: any[], | ||
| options: Partial<DataContainerOptions> = defaultOptions |
There was a problem hiding this comment.
both inputDataFormat and fields are optional, this should just be options: DataContainerOptions
heshan0131
reviewed
Mar 18, 2022
| @@ -18,34 +18,44 @@ | |||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | |||
| // THE SOFTWARE. | |||
|
|
|||
| import {DataContainerInterface} from './data-container-interface'; | |||
|
|
|||
| export type SharedRowOptions = DataRow | boolean | undefined; | |||
There was a problem hiding this comment.
maybe move to the end of this file, after DataRow is defined?
heshan0131
reviewed
Mar 18, 2022
| import {RGBColor} from 'reducers/types'; | ||
| import {Layer} from 'layers'; | ||
| import {Filter} from 'reducers/vis-state-updaters'; | ||
| import {FieldDomain} from 'reducers/vis-state-updaters'; |
There was a problem hiding this comment.
merge 2 imports from 'reducers/vis-state-updaters'
heshan0131
approved these changes
Mar 18, 2022
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
…_ts_convertion_utils_table_utils
Signed-off-by: Maksim Suslov <maksim.suslov@actionengine.com>
delete-merged-branch
bot
deleted the
ms/js_to_ts_convertion_utils_table_utils
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.