[Fix] basemap frozen when incrementally loading GeoArrow #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixun910
commented
Dec 11, 2023
ibgreen
approved these changes
Dec 13, 2023
| @@ -19,7 +19,7 @@ | |||
| // THE SOFTWARE. | |||
|
|
|||
| import * as arrow from 'apache-arrow'; | |||
| import {BinaryFeatures} from '@loaders.gl/schema'; | |||
| import {BinaryFeatureCollection} from '@loaders.gl/schema'; | |||
There was a problem hiding this comment.
Was this module not upgraded to 4.0? If not, this looks confusing if loaders 4.0 is exporting two such similar types...
There was a problem hiding this comment.
I think it’s because the "@loaders.gl/schema": "^4.1.0-alpha.2" was missing in package.json. Should be fixed in this PR.
|
Ok let me try to get a alpha.4 out sooner rather than later. |
Signed-off-by: Xun Li <lixun910@gmail.com>
Signed-off-by: Xun Li <lixun910@gmail.com>
Signed-off-by: Xun Li <lixun910@gmail.com>
Signed-off-by: Xun Li <lixun910@gmail.com>
lixun910
force-pushed
the
xli/fix-incremental-load-geoarrow
branch
from
488f1e2 to
2705260
Compare
Signed-off-by: Xun Li <lixun910@gmail.com>
chrisgervang
pushed a commit
to chrisgervang/kepler.gl
that referenced
this pull request
Dec 19, 2023
Signed-off-by: Chris Gervang <chris@gervang.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: It seems the basemap refreshing could be frozen when testing incremental loading GeoArrow file using https://kepler.gl/demo, which is different than the rendering behavior when testing on local dev env (see screenshot in #2459):
This PR is to fix this issue by slightly delaying the nextFileBatch action to avoid the racing condition between basemap rendering and deck.gl geojson layer rendering: