Remove unused parts of translation files #2494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkskyum
force-pushed
the
remove-unused-parts-of-translation-files
branch
from
cca9540
to
726213b
Compare
birkskyum
force-pushed
the
remove-unused-parts-of-translation-files
branch
2 times, most recently
from
3f32127
to
e493795
Compare
|
@ibgreen , there is a bit of confusion about how to add custom styles. This clarified the translations and is a cleanup step. There has for a long time (since before i started looking into kepler.gl) been a bug related to a disabled "add style" button that I'd like to debug when this is in. |
Signed-off-by: Birk Skyum <birk.skyum@pm.me>
Signed-off-by: Birk Skyum <birk.skyum@pm.me>
Signed-off-by: Birk Skyum <birk.skyum@pm.me>
birkskyum
force-pushed
the
remove-unused-parts-of-translation-files
branch
from
e493795
to
c9f3283
Compare
✅ Deploy Preview for keplergl2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a style previously requested an api key, but these fields are now commented out because a potential style api key are a part of the style url, so the translations aren't needed either.
it also resolves some step numbering inconsistencies:
before:
after:
