-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore]: Upgrade to yarn 4 #2610
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
1a735e8
[chore]: Upgrade to yarn 4
heshan0131 3aea9a9
remove yarnPath for github action to run
heshan0131 55b7a55
use volta
heshan0131 9c939fd
run yarn install first
heshan0131 93a5b05
skip install puppeteer
heshan0131 a833d72
move fix-dependency script to bootstrap
heshan0131 07243b5
run bootstrap
heshan0131 324bf1f
run yarn install first
heshan0131 0f3b8c1
fix website build
heshan0131 cfabbc8
add yarn.lock and try again
heshan0131 621971f
netlify deploy fix attempt 1- run to clean yarn cache in yarn deploy …
heshan0131 60fc619
rebase and run yarn
heshan0131 21dc069
netlify deploy fix attempt 2 - set YARN_VERSION in env vaariables
heshan0131 74e19f3
update yarn version in submodules
heshan0131 bd0b56f
netlify deploy fix attempt 3: disable globale cache
heshan0131 ae37e2f
fix kepler-jupyter bindings package.json
heshan0131 c337c90
netlify deploy fix attempt 4: resolve examples/demo-app nodemodules
heshan0131 864e23b
netlify deploy fix attempt 5: resolve examples/demo-app node modules
heshan0131 088e150
netlify deploy fix attempt 6: calling install twice
heshan0131 3b1583f
netlify deploy fix attempt 7: try add @auth0/auth0-spa-js to website/…
heshan0131 9681566
netlify deploy fix attempt 8: attempt to rename maybe case sensitive …
heshan0131 9ce18ec
netlify deploy fix attempt 9: import auth0 somewhere else for debug
heshan0131 4e762f0
netlify deploy fix attempt 9: add resolve to netlify config
heshan0131 69b34d7
netlify deploy fix attempt 10: add react-router to root package.json …
heshan0131 470f53e
netlify deploy fix attempt 11: add yarnrc to website and demo-app
heshan0131 c53e5de
netlify deploy fix attempt 12: reorder install:examples script
heshan0131 3aea6cf
revert change to website webpack.config
heshan0131 dd59d25
update DEVELOPERS.md to include Volta
heshan0131 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
# https://yarnpkg.com/configuration/yarnrc | ||
nodeLinker: node-modules | ||
# Define the registry to use when fetching packages. | ||
npmRegistryServer: 'https://registry.yarnpkg.com' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,5 @@ dist/ | |
temp.* | ||
babel/ | ||
|
||
yarn.lock | ||
yarn-error.log | ||
package-lock.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the yarn4 gitignore recommendations that I have been following in the vis.gl repos https://github.com/visgl/luma.gl/blob/master/.gitignore#L33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am trying different things to get netlify deployment works on this PR. So far I noticed if I don't have yarn.lock in the website and examples/demo-app folder, running yarn install in these two folders to build the website will fail with a 'issing yarn.lock' message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you should check in the yarn.lock file