[fix] revert replaced deprecated "assert" with "with" #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
igorDykhta
commented
Sep 18, 2024
igorDykhta
commented
- We are still working with node 18, and "with" was introduced in node 20
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
❌ Deploy Preview for keplergl2 failed. Why did it fail? →
|
|
I believe that IMHO, the way this was handled by Node is a big mess. Haven't been able to upgrade loaders.gl to Node 22 because of this. It seems to me that wouldn't have cost much to stay backwards compatible with |
heshan0131
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.