[Enhancement] support mapbox url protocol #2693
Merged
+29
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add maplibregl-mapbox-request-transformer" * Modify transformRequeset at src/util Signed-off-by: Sahit Tuntas Sadono <sahitsadono@gmail.com>
✅ Deploy Preview for keplergl2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks for adding this! You'll probably also want to add it in map-container.tsx |
Signed-off-by: Sahit Tuntas Sadono <sahitsadono@gmail.com>
|
Got it @akre54 , just add it to map-container.tsx |
|
Awesome work! Just pulled this and verified locally I was able to get custom base maps using the |
akre54
requested review from
ibgreen,
heshan0131,
igorDykhta and
macrigiuseppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sahit Tuntas Sadono sahitsadono@gmail.com
This will allow mapbox protocol and close #2560
But i am not sure where is the map initialized, so i set it at add-map-modal. If there is any other maplibre initializer then i can modify it