Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Collapsible layer group #350

Merged
merged 4 commits into from
Feb 5, 2019
Merged

[Feature] Collapsible layer group #350

merged 4 commits into from
Feb 5, 2019

Conversation

heshan0131
Copy link
Contributor

  • Add collapsible layer group
  • Default state to be collapsed

collapsible-layer-group

@heshan0131
[Bug]: fix alias and module resolve in webpack.config.local
d02a49c
@heshan0131
lint
61a8838
@heshan0131
[Enhancement] Add collapsible layer group
4ee0e4b 
- add more sample data

- fix all layer config rendering

- Keep basic config group expanded if missing columns
@heshan0131
comment out example data
e4c2e80
@heshan0131 heshan0131 added feature A new feature enhancement An update of a existing feature labels Jan 31, 2019
@heshan0131 heshan0131 added this to the Milestone (Jan 14, 2019) milestone Jan 31, 2019
@heshan0131
Copy link
Contributor Author

#340

@macrigiuseppe
Copy link
Collaborator

It looks good.
Only one comment, I am not sure the three point icon is the best choice. Usually that icon is not used for expanding/collapsing but more as action menu. I have seen the same icon used to describe a drag&drop action.

@heshan0131 heshan0131 merged commit 2bb74e5 into master Feb 5, 2019
@macrigiuseppe macrigiuseppe deleted the collapsible-layer-group branch May 2, 2019 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macrigiuseppe macrigiuseppe macrigiuseppe approved these changes

Assignees
No one assigned
Labels
enhancement An update of a existing feature feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heshan0131 @macrigiuseppe