[Feat] Support Policy page #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macrigiuseppe
force-pushed
the
support_policy
branch
from
fdafc9e
to
dbcc296
Compare
heshan0131
reviewed
Sep 11, 2019
website/src/components/policy.js
Outdated
| max-width: unset; | ||
|
|
||
| .kg-home__caption__description { | ||
| max-width: unset; |
There was a problem hiding this comment.
can you add a max-width: 800px to this, so it doesn't expand all the way to a 2000px widescreen?
heshan0131
reviewed
Sep 11, 2019
website/src/components/policy.js
Outdated
| <a href="https://kepler.gl">Kepler.gl</a> is an open source project. Its source code is available at <a | ||
| href={GITHUB_PROJECT}>Kepler.gl Github project</a>. | ||
| </h3> | ||
| <span> |
There was a problem hiding this comment.
make this font-weight: 500?
macrigiuseppe
commented
Sep 11, 2019
website/src/components/policy.js
Outdated
| and you can participate in the development of the project's source code. Bug reports and | ||
| issues can be submitted at <a | ||
| href={GITHUB_PROJECT_ISSUES}>Kepler.gl Github issues</a>. | ||
| [Questions can be asked on the project's mailing lists, which you can subscribe to at [URL] // NEED TO BE DEFINED] |
There was a problem hiding this comment.
@heshan0131 can you help with this? What should be the url for mailing list subscription? if we have one
There was a problem hiding this comment.
Signed-off-by: Giuseppe Macri <gmacri@uber.com>
|
@heshan0131 updated with your feedback |
Signed-off-by: Giuseppe Macri <gmacri@uber.com>
macrigiuseppe
force-pushed
the
support_policy
branch
from
dbcc296
to
a740be8
Compare
heshan0131
approved these changes
Sep 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new support policy page
Signed-off-by: Giuseppe Macri gmacri@uber.com