add: support of user command #175
Conversation
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -29,6 +29,7 @@ public static class RunOptions { | |||
| private boolean debug; | |||
| private int port; | |||
| private String path; | |||
| private String appCmd; | |||
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck> reported by reviewdog 🐶
Missing a Javadoc comment.
| @@ -73,6 +74,14 @@ public void setDebug(boolean debug) { | |||
| this.debug = debug; | |||
| } | |||
|
|
|||
| public void setappCmd(String appCmd) { | |||
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck> reported by reviewdog 🐶
Class 'RunOptions' looks like designed for extension (can be subclassed), but the method 'setappCmd' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RunOptions' final or making the method 'setappCmd' static/final/abstract/empty, or adding allowed annotation for the method.
| @@ -73,6 +74,14 @@ public void setDebug(boolean debug) { | |||
| this.debug = debug; | |||
| } | |||
|
|
|||
| public void setappCmd(String appCmd) { | |||
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> reported by reviewdog 🐶
Missing a Javadoc comment.
| @@ -73,6 +74,14 @@ public void setDebug(boolean debug) { | |||
| this.debug = debug; | |||
| } | |||
|
|
|||
| public void setappCmd(String appCmd) { | |||
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck> reported by reviewdog 🐶
Parameter appCmd should be final.
| @@ -73,6 +74,14 @@ public void setDebug(boolean debug) { | |||
| this.debug = debug; | |||
| } | |||
|
|
|||
| public void setappCmd(String appCmd) { | |||
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck> reported by reviewdog 🐶
'appCmd' hides a field.
| this.appCmd = appCmd; | ||
| } | ||
|
|
||
| public String getappCmd() { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck> reported by reviewdog 🐶
Class 'RunOptions' looks like designed for extension (can be subclassed), but the method 'getappCmd' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RunOptions' final or making the method 'getappCmd' static/final/abstract/empty, or adding allowed annotation for the method.
| this.appCmd = appCmd; | ||
| } | ||
|
|
||
| public String getappCmd() { |
There was a problem hiding this comment.
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> reported by reviewdog 🐶
Missing a Javadoc comment.
Related Issue
Closes: #[issue number that will be closed through this PR]
Describe the changes you've made
A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!
Type of change
How did you test your code changes?
Please describe the tests(if any). Provide instructions how its affecting the coverage.
Describe if there is any unusual behaviour of your code(Write
NAif there isn't)A clear and concise description of it.
Checklist:
Screenshots (if any)