Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: ts-sdk records keploy-testcase even on test mode #430

Closed
1 task done
re-Tick opened this issue Feb 22, 2023 · 11 comments · Fixed by keploy/typescript-sdk#86
Closed
1 task done

[bug]: ts-sdk records keploy-testcase even on test mode #430

re-Tick opened this issue Feb 22, 2023 · 11 comments · Fixed by keploy/typescript-sdk#86
Labels
bug Something isn't working Good First Issue Good for newcomers GSoC Issues up for GSoC Repo/@typescript-sdk Issue Related to Keploy TS-SDK Repository

Comments

@re-Tick
Copy link
Contributor

re-Tick commented Feb 22, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

When, I run the application on test mode, and do an API call on endpoint then this will record testcases.

Ideally it should just return the responses and not record Keploy-testcases on test mode.

Steps to reproduce

  1. Run the self-hosted Keploy server. Follow the Quick installation guide
  2. Integrate ts-sdk or use the sample-typescript application.
  3. Run the application on test mode.
  4. Do an API call on the endpoint of running application.
  5. A Keploy-testcase is generated

Environment

None

Version

Cloud
@re-Tick re-Tick added bug Something isn't working Good First Issue Good for newcomers labels Feb 22, 2023
@re-Tick re-Tick assigned re-Tick and unassigned re-Tick Feb 23, 2023
@frey0-0
Copy link

frey0-0 commented Feb 23, 2023

Hello @re-Tick please assign me this issue! I can't assign it to myself for some reason.

@re-Tick
Copy link
Contributor Author

re-Tick commented Feb 23, 2023

Done. Looking forward for your PR

shreyanshshah27 referenced this issue in shreyanshshah27/typescript-sdk Feb 23, 2023
@shreyanshshah27
bugfix - gh-42
e175d67
@shreyanshshah27
Copy link

Hey @re-Tick

I've tried to fix this issue. It would be great if you can review the PR.

@shreyanshshah27
Copy link

Hey @frey0-0

My sincere apologies, I had already stated working on this issue and by the time I notice that, this issue has been assigned to you, I had already made the fix. I hope you can understand.

shreyanshshah27 referenced this issue in shreyanshshah27/typescript-sdk Feb 23, 2023
@shreyanshshah27
bugfix - gh-42
8903359 
Signed-off-by: Shreyansh Shah <shreyansh_shah@yahoo.com>
@re-Tick
Copy link
Contributor Author

re-Tick commented Feb 24, 2023 •
edited
Loading

Hi @shreyanshshah27, please look for unassigned issues. Hey @frey0-0, don't worry I will be adding some more GFI's for TS-SDK, you can pick from them.

This changes looks good to me, have you tried to make API call during test mode.

@shreyanshshah27
Copy link

@re-Tick Definitely, I'll take care of it from the next time.

Yes, I've tried making API call during test mode and those weren't getting recorded.

@frey0-0
Copy link

frey0-0 commented Feb 24, 2023

Yeah sure @re-Tick, not a problem I have my uni exams(last night preps you know how it is) coming up so I will get back to work next weekend :))

@AnkitKumarvaid AnkitKumarvaid transferred this issue from keploy/typescript-sdk Mar 4, 2023
@AnkitKumarvaid AnkitKumarvaid added the Repo/@typescript-sdk Issue Related to Keploy TS-SDK Repository label Mar 4, 2023
@frey0-0
Copy link

frey0-0 commented Mar 9, 2023

Hey @re-Tick is this still open? If yes I would like to complete it.

@re-Tick
Copy link
Contributor Author

re-Tick commented Mar 9, 2023

There is a PR opened for this. You can discuss those changes and can propose your changes.

@frey0-0 frey0-0 mentioned this issue Mar 10, 2023
Closed
@frey0-0
Copy link

frey0-0 commented Mar 10, 2023

I have linked a PR for this issue. Please review it @re-Tick ✨

@nehagup nehagup added the GSoC Issues up for GSoC label Mar 13, 2023
G0maa added a commit to G0maa/typescript-sdk that referenced this issue Mar 18, 2023
@G0maa
fix: record even on test mode
523e270 
- Solves keploy/keploy#430
- Methodology: Treat as MODE_OFF in middleware and afterMiddleware functions

Signed-off-by: G0maa <midomaxgomaa@gmail.com>
@G0maa G0maa mentioned this issue Mar 18, 2023
Open
@VishalMyla
Copy link

@re-Tick Please review this PR

@Sekhar-Kumar-Dash Sekhar-Kumar-Dash mentioned this issue Mar 31, 2023
Merged
manasmanohar pushed a commit to manasmanohar/keploy that referenced this issue Jan 10, 2025
@gouravkrosx
fix: logic for ignoring code refactoring in utg (keploy#430)
df2dac5 
* chore: refactor logic for ignoring code refactoring in utg

Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>

* fix: inverted logic

Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>

---------

Signed-off-by: gouravkrosx <gouravgreatkr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Good First Issue Good for newcomers GSoC Issues up for GSoC Repo/@typescript-sdk Issue Related to Keploy TS-SDK Repository
Projects
None yet
Milestone
No milestone
6 participants
@nehagup @shreyanshshah27 @re-Tick @AnkitKumarvaid @frey0-0 @VishalMyla