fixing: ts-sdk records keploy-testcase even on test mode #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
|
@re-Tick Please review this PR |
|
This expression should also check for the empty KEPLOY_TEST_ID from the headers. Since, during the simulate request of test mode, the KEPLOY_TEST_ID is used for check. Also there should be check in the afterMiddleware function also which will just return the response instead of recording it. |
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
|
@re-Tick please check the it again |
|
Please add the if check in afterMiddleware also after this "if check" |
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
|
LGTM. |
re-Tick
added
Don't Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR closes: keploy/keploy#430