Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : do not record test-case while in test mode #46

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix : do not record test-case while in test mode #46

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a170453
fix: do not record tc when in test mode
shreyanshshah27 Feb 23, 2023
7436c5a
fix: review comments
shreyanshshah27 Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions integrations/express/middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,9 @@ export function afterMiddleware(keploy: Keploy, req: Request, res: Response) {
return;
}

if (process.env.KEPLOY_MODE=="test") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use MODE_TEST constant intead of "test" here and use "equality without type coersion”.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor

@re-Tick re-Tick Mar 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

return res
}
// req.headers
// Since, JSON.stingify trims spaces. Therefore, content-length of request header should be updated
req.headers["content-length"] = JSON.stringify(
Expand Down