Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added unittest for octokit module #64

Closed
wants to merge 14 commits into from

Conversation

Sekhar-Kumar-Dash
Copy link
Contributor

Related Issue
Info about Issue or bug
Closes: keploy/keploy#354

Describe the changes you've made
Added a unit test for integrations/octokit module's wrappedNodeFetch function using typescript sdk.

Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@Sonichigo
Copy link
Member

Can @re-Tick please review the PR ?

@re-Tick
Copy link
Contributor

re-Tick commented Mar 15, 2023

Hi @Sekhar-Kumar-Dash, Please add a job in .github action to run the test files and give code coverage

Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@Sekhar-Kumar-Dash
Copy link
Contributor Author

Sekhar-Kumar-Dash commented Mar 16, 2023

Hi @Sekhar-Kumar-Dash, Please add a job in .github action to run the test files and give code coverage

@re-Tick i updated the files please check

Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
.github/workflows/ci.yml Outdated Show resolved Hide resolved
newtest/unittest1.ts Outdated Show resolved Hide resolved
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@Sekhar-Kumar-Dash
Copy link
Contributor Author

@re-Tick updated the files please check it

@re-Tick
Copy link
Contributor

re-Tick commented Mar 20, 2023

There should be some more testcases in unit test for test, off mode. And please resolve the errors in the cli.

Sekhar-Kumar-Dash and others added 8 commits March 23, 2023 20:33
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
Signed-off-by: sekhar kumar dash <sekharkumardash229@gmail.com>
@Sekhar-Kumar-Dash
Copy link
Contributor Author

There should be some more testcases in unit test for test, off mode. And please resolve the errors in the cli.

please review the new pr had to delete the last one because vscode updated somefiles on its own which cause merge conflicts
i have added some more test cases and resolved all the cli please check it here
#74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test]: add unit tests for octokit module
3 participants