Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add musicbrainzid as parameter alias #15

Closed
wants to merge 1 commit into from

Conversation

RustyNova016
Copy link
Contributor

Currently, the website looks for the parameter mbid in the URL. However, mbid often is associated with tracking and on browsers with any decent tracking protection (like Firefox and Librewolf, or extensions), this parameter get removed from the url.

So I added a alias that doesn't get flagged as tracking, and kept the old one as well for backward compatibility

@kepstin
Copy link
Owner

kepstin commented Sep 17, 2024

I've merged this code into the beta branch, and deployed it to https://magicisrc-beta.kepstin.ca/ - I've also updated the seeding documentation with information about the new parameter name and why someone might want to use it.

I'm testing this now and would appreciate any other feedback - hopefully i can deploy it to the main site soon.

@RustyNova016
Copy link
Contributor Author

Neat! I will be able to finally add isrc from harmony... Well I need to ready the PR over there too.

@kepstin
Copy link
Owner

kepstin commented Sep 22, 2024

Released in v20240922.0 with a fix to remove the duplicate parameter from the URL after the page loads.

@kepstin kepstin closed this Sep 22, 2024
@RustyNova016
Copy link
Contributor Author

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants