Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic minc tracklists support (MASS ISRC list paste) #2

Closed
wants to merge 5 commits into from
Closed

Basic minc tracklists support (MASS ISRC list paste) #2

wants to merge 5 commits into from

Conversation

jesus2099
Copy link

This is the draft of a PR for “Support pasting multiple isrcs.” (#1)

It allows to paste a bunch of ISRC starting from whichever track input field.

  • It works with minc tracklists.
  • It does not skip tracks with no ISRC.
    It may be difficult to do in the future with my current approach.
  • @kepstin, sendEvent is ATM useless, I can remove it.

- it works with minc tracklists.
- it does not skip tracks with no ISRC.
  It may be difficult to do in the future with my current approach.
- @kepstin, sendEvent is ATM useless, I can remove it.
@jesus2099
Copy link
Author

Tell me what to change in my code to suit your tastes or anything. :)

@kepstin
Copy link
Owner

kepstin commented Oct 18, 2016

Hmm. I think rather than allowing people to paste multiple ISRCs into the existing text boxes, it would be better to have a (large?) text field, probably at the top, to paste blocks of text. I'd want to do explicit parsing - i.e. have a "Parse" button beside it rather than automatically parse on paste, and maybe a select box to choose the disk to apply the isrcs to ("all disks", "disk 1", "disk 2", etc)

Please don't put a version number in the title.

@jesus2099
Copy link
Author

jesus2099 commented Oct 18, 2016

The ability to paste in any track was useful to me for releases with holes like the following, where I had to use notlob.eu because of skip tracks (isrcsubmit.exe cannot cope when there are holes, at least especially when there is no ISRC on track 1):

Even in minc, it’s not really rare (they reflect what’s on CD BTW).
Let’s take Edit #18227856 - Add ISRCs to illustrate what I mean:

  1. I used mediatools.exe — same with minc’s SRCL-2471 page — to display the ISRC table
  2. I can copy rows 2 and 3
  3. Paste them in your page’s 2nd track
  4. Copy remaining rows 9〜14
  5. Paste them in your page’s 9th track

This way I can submit 8 ISRC with only two copy/pastes instead.

I tried it with the data (both mediatools.exe and minc verbatims) you can copy from the edit note I’ve linked and the release MBID that’s over there as well.


The ability to not stop at a medium’s end is that I can use the above method to cover any amount of mediums.


Covering those cases would be made more complex with one or several separate text areas and some select combos. No ?

@jesus2099
Copy link
Author

“track skip” demo

mass magicisrc with track skip

@jesus2099
Copy link
Author

“medium span” demo

mass magicisrc with medium span

@jesus2099
Copy link
Author

I close this as it was for previous version of MAGIC ISRC. :)

@jesus2099 jesus2099 closed this Jul 5, 2019
jesus2099 added a commit to jesus2099/konami-command that referenced this pull request Dec 4, 2019
@jesus2099 jesus2099 deleted the #1-support-pasting-multiple-isrcs branch July 14, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants