Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate Lighthouse CI #17

Merged
merged 2 commits into from
Aug 31, 2022
Merged

feat: Integrate Lighthouse CI #17

merged 2 commits into from
Aug 31, 2022

Conversation

iamrajiv
Copy link
Member

@iamrajiv iamrajiv commented Aug 12, 2022

Fixes: #16
Related: keptn/keptn.github.io#994

Signed-off-by: Rajiv Ranjan Singh <rajivperfect007@gmail.com>
@netlify
Copy link

netlify bot commented Aug 12, 2022

Deploy Preview for keptn-experimental-docs-site ready!

Name Link
🔨 Latest commit e9d5982
🔍 Latest deploy log https://app.netlify.com/sites/keptn-experimental-docs-site/deploys/62f62eae3914850008831faf
😎 Deploy Preview https://deploy-preview-17--keptn-experimental-docs-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Aug 12, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 71
🟢 Accessibility 100
🟢 Best practices 93
🟢 SEO 90
🟠 PWA 64

Lighthouse ran on https://deploy-preview-17--keptn-experimental-docs-site.netlify.app/

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Might want to clarify the description just a bit...

@imsingh
Copy link

imsingh commented Aug 15, 2022

I'd suggest to actually create a table to show seperate report of each page that you send to lighthouse. Additionally, you can link the full lighthouse report in that table.

Otherwise, just like this, the report is not much useful.

@iamrajiv iamrajiv changed the title feat: Add Lighthouse CI feat: Integrate Lighthouse CI Aug 16, 2022
@iamrajiv iamrajiv mentioned this pull request Aug 22, 2022
21 tasks
@iamrajiv iamrajiv merged commit 8d37d54 into main Aug 31, 2022
@iamrajiv iamrajiv deleted the lh-ci branch September 10, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Lighthouse CI in the docs engine
3 participants