Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

feat: Introduce skipping of automatic event responses per task handler #537

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

warber
Copy link
Contributor

@warber warber commented Sep 5, 2022

closes keptn/keptn#8718

This PR introduces the possibility to skip automatic event responses (sending of started/finished events by the sdk) on a per task handler basis.
Usage:

log.Fatal(sdk.NewKeptn(
	serviceName,
	sdk.WithTaskEventHandler(
		echoTriggeredEventType,
		NewEchoHandler(), sdk.TaskHandlerOptions{
			SkipAutomaticResponse: true,
		}),
	sdk.WithLogger(logrus.StandardLogger()),
).Start())

Signed-off-by: warber <bernd.warmuth@dynatrace.com>
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@f07eb2f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #537   +/-   ##
=========================================
  Coverage          ?   50.53%           
=========================================
  Files             ?      105           
  Lines             ?     5802           
  Branches          ?        0           
=========================================
  Hits              ?     2932           
  Misses            ?     2737           
  Partials          ?      133           

Signed-off-by: warber <bernd.warmuth@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@warber warber merged commit 278ad8b into master Sep 7, 2022
@warber warber deleted the feat/8718/sdk-automatic-response-per-handler branch September 7, 2022 06:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keptn configure monitoring sends inconsistent Cloud Event types, leading to problems with go-sdk
2 participants