Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DataDog as Evaluation Provider #554

Closed
thisthat opened this issue Dec 22, 2022 · 7 comments · Fixed by #948
Closed

Add support for DataDog as Evaluation Provider #554

thisthat opened this issue Dec 22, 2022 · 7 comments · Fixed by #948
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@thisthat
Copy link
Member

thisthat commented Dec 22, 2022

Goal

Support Datadog as KeptnEvaluationProvider.

Technical Details

In Keptn v1, we have integration for different observability providers. In particular, we have a Datadog integration.
There should be also such support in the Keptn Lifecycle Toolkit.
For this, the following is required:

  • Add an entry in the provider selector (code)
  • Introduce a new datadog.go file in the providers folder that contains the integration logic
  • Add unit tests
  • Update the KLT Docs

Reference

The Prometheus and Dynatrace integrations can be used as a reference.
Go Client for DD

@thisthat thisthat added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 22, 2022
@thisthat
Copy link
Member Author

@vadasambar you might be interested in this :)

@vadasambar
Copy link
Member

@vadasambar you might be interested in this :)

Thank you for the mention @thisthat. I don't know the complete context but this sounds interesting.

@shardulsrivastava
Copy link
Contributor

@thisthat I would like to work on this.

@thisthat
Copy link
Member Author

Thanks @shardulsrivastava 👍

@sudiptob2
Copy link
Member

Hi, @thisthat
I am interested in this issue. As there hasn't been any activity from shardulsrivastava for a long time, could you please re-assign it to me?

@thisthat
Copy link
Member Author

Hey @sudiptob2 thanks for stepping in 🚀

sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 17, 2023
Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 17, 2023
Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 17, 2023
Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 27, 2023
Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 27, 2023
Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 27, 2023
Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
@agardnerIT
Copy link
Contributor

agardnerIT commented Mar 25, 2023

@thisthat This thread is being used as an implementation reference by others to create metrics providers. Therefore, although it is closed, please consider updating the links in the first post as they're all now dead.

All links 404.

@sudiptob2 Would you consider presenting what you've learned on a community call? A LOT of people would benefit from your knowledge and learnings. The docs team can also take that content to get a proper docs page started so hopefully with one call, we can:

  1. Have a reference video and screenshare
  2. Get a proper docs page started for this activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
5 participants